Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge to master to trigger release #610

Merged
merged 21 commits into from
Sep 26, 2024
Merged

merge to master to trigger release #610

merged 21 commits into from
Sep 26, 2024

Conversation

dominik-cnx
Copy link
Collaborator

No description provided.

@dominik-cnx
Copy link
Collaborator Author

@mcweba are we fine with these changes?

image

@mcweba
Copy link
Collaborator

mcweba commented Sep 23, 2024

@mcweba are we fine with these changes?

image

No these changes should not be in develop branch

Copy link
Collaborator

@mcweba mcweba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge as long as the commits from @steniobhz are in develop

@dominik-cnx
Copy link
Collaborator Author

@steniobhz can your revert these changes and work on this task in a dedicated branch?

@dominik-cnx
Copy link
Collaborator Author

Awaiting revert of unintentional commits.

Almeida Stenio added 3 commits September 25, 2024 16:41
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.44%. Comparing base (fc56891) to head (110c4af).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
...isspush/gateleen/monitoring/MonitoringHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #610      +/-   ##
============================================
- Coverage     48.81%   48.44%   -0.37%     
+ Complexity     1878     1862      -16     
============================================
  Files           238      238              
  Lines         11953    11953              
  Branches       1261     1261              
============================================
- Hits           5835     5791      -44     
- Misses         5614     5659      +45     
+ Partials        504      503       -1     
Flag Coverage Δ
48.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dominik-cnx dominik-cnx merged commit 49d681f into master Sep 26, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants